Fix buggy syntax highlighting behavior involving "?" #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that if no other syntax highlighting rules apply, a question mark will "pop" in terms of highlighting.
The original approach created more problems than it solved. Additionally, the desired syntax highlighting behavior is handled gracefully via `rx` and the `rx-constituents` approach I gleaned from puppet-mode.el.
mattdeboard
added a commit
that referenced
this pull request
Aug 16, 2014
Fix buggy syntax highlighting behavior involving "?"
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
Also remove an old individual app lock file (that wasn't used)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
Fixes #29
Fixes #30
Fixes #36
Refs #23
These fixes all stem from removing
elixir-syntax-propertizeand instead relying on the regex creation work inelixir-rxandelixir-rx-constituents. In short, by adding a font face to thecode-pointregex constituent, and putting it last in the list of defaults, it ensures the "escape character" fontification for the question mark will only be used as a last resort.Regarding #23, that is still a failing test. I think there will need to be some further use of
rxto ensure that the"character does not override the~r//pattern. That is, a regex closure should signal the end of any previous fontification. It doesn't now, but it should.