Rewrite token emitting functions #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous incarnation of this is quite slow and very hard to follow. In this commit I am trying to see how concise I can make the forward- and backward-token functions.
Also, broke up 80+ lines.
mattdeboard
added a commit
that referenced
this pull request
Aug 18, 2014
Rewrite token emitting functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
elixir-smie-forward-tokenandelixir-smie-backward-tokendispatched to a single larger function calledelixir-smie-next-tokenwhich in turn dispatched to a much larger function calledelixir-smie-next-token-no-lookaround.This patch removes those layers in favor of relying on SMIE's machinery to do most of the heavy lifting.
Fixes #67
Fixes #76