Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElixirLS should detect . as the project directory and raise an error #536

Closed
axelson opened this issue Apr 20, 2021 · 2 comments · Fixed by #587
Closed

ElixirLS should detect . as the project directory and raise an error #536

axelson opened this issue Apr 20, 2021 · 2 comments · Fixed by #587
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@axelson
Copy link
Member

axelson commented Apr 20, 2021

elixirLS.projectDir having the value . causes the extension to not work. We should either ignore . or raise an issue

Results in an error like Skipping build because cwd changed from /home/jason/dev/gen_tracker/. to /home/jason/dev/gen_tracker in the output log

@fmterrorf
Copy link

Hi 👋 I'd like to take a stab at this issue. I see your comment here #427 (comment)

I agree that a warning would be a good improvement. Should we go even further and ignore a value of . replacing it with ""? (this would be in addition to the warning).

That would be done here correct? Where we'll check if the rootPath is . and replace it with ""

@lukaszsamson
Copy link
Collaborator

@fmterrorf I would not pollute this module with settings validation. Let's do it in server.ex in set_settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants