Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to handle multi-root workspaces on vscode (elixir-lsp/vscode-elixir-ls#70) there's the need to spawn multiple language servers (one per project).
This is currently not possible because the server registers the
spec
command for every instance and so no more than one server can be spawned at the same time.This PR fixes that by generating an unique id every time is initialized.
Just a couple questions, is
id
ok? Or maybeserver_id
orinstance_id
might be better?Regarding testing, should I test that
defp handle_request(initialize_req...
sets a new id on the state?