Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor :inputs option in .formatter.exs #315

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Honor :inputs option in .formatter.exs #315

merged 1 commit into from
Jul 13, 2020

Conversation

jayjun
Copy link
Contributor

@jayjun jayjun commented Jul 10, 2020

mix format reads the :inputs option in .formatter.exs to include files.

This pull request makes ElixirLS check the same :inputs option to decide if a file should be formatted.

Fixes elixir-lsp/vscode-elixir-ls#120.

@jayjun jayjun mentioned this pull request Jul 10, 2020
Closed
@axelson
Copy link
Member

axelson commented Jul 10, 2020

Thanks for this! It looks good. Could you add a test for this functionality? I'll work on trying to get the test suite back to green.

@jayjun
Copy link
Contributor Author

jayjun commented Jul 11, 2020

Test added. Behaviour changes according to .formatter.exs so I must make the inner implementation public and unit test that instead.

axelson
axelson approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test ❤️!

@axelson axelson merged commit 30f7931 into elixir-lsp:master Jul 13, 2020
axelson added a commit that referenced this pull request Jul 13, 2020
@axelson
Update changelog for #315
767e174
@jayjun jayjun deleted the inputs branch July 14, 2020 03:17
@jayjun jayjun mentioned this pull request Jul 21, 2020
Closed
2 tasks
@drewolson drewolson mentioned this pull request Aug 19, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelson axelson axelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support .formatter config
2 participants
@jayjun @axelson