Fix the test suite #352
Merged
Fix the test suite #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This gets the tests to pass! Although it would be nice to not need to commit the 1.4MB PLT file to the repository, but if it's the specific PLT for the tests than maybe that's fine. Although it would be nice to host this PLT and other PLT's in a GitHub release so that they can be dynamically downloaded on startup. Although there's a very large number of potential combinations so I'm not sure it's feasible to build them all. |
I think it's making it more difficult to track down the actual issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of debugging, I believe that issue that was ailing our test suite was a compiler deadlock that manifested in Erlang 23 https://bugs.erlang.org/browse/ERL-1236
So simply upgrading the erlang version resolved the issue.