Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid value set in write_manifest_pid #430

Merged
merged 4 commits into from
Dec 6, 2020

Conversation

lukaszsamson
Copy link
Collaborator

Without fixing it

if state.write_manifest_pid, do: Process.exit(state.write_manifest_pid, :kill)

will crash with ArgumentError and
if is_pid(write_manifest_pid), do: Process.exit(write_manifest_pid, :cancelled)

will have no effect, which was actually good as exiting a linked process will bring down the caller

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Just making a small wording change to indicate that the write manifest may not be cancelled.

apps/language_server/lib/language_server/dialyzer.ex Outdated Show resolved Hide resolved
apps/language_server/lib/language_server/dialyzer.ex Outdated Show resolved Hide resolved
apps/language_server/lib/language_server/dialyzer.ex Outdated Show resolved Hide resolved
apps/language_server/lib/language_server/dialyzer.ex Outdated Show resolved Hide resolved
@axelson axelson merged commit 3b2c51b into elixir-lsp:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants