Clean up the API to expose Huffman encoding #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
approved these changes
Apr 26, 2023
| Same as `new/2` with default options. | ||
| """ | ||
| @spec new(non_neg_integer()) :: Table.t() | ||
| def new(max_table_size), do: new(max_table_size, []) |
There was a problem hiding this comment.
What about adding a default argument to new/2 instead:
def new(max_table_size, options \\ [])There was a problem hiding this comment.
I did this initially, but then we cannot use @doc since. 🙃
Pull Request Test Coverage Report for Build 3d1be8ebe889621e0f70f2daa63654f6ebaf89cf-PR-13Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.