Add an explicit step to a range #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the line emits a warning when compiled with Elixir 1.17
|
CI is failing. Can you take a look? I’m without laptop til Monday so I can't look til then. |
Pull Request Test Coverage Report for Build 5144500fdf6d662f7f3b1134f63baa8ba4cadd5f-PR-15Details
💛 - Coveralls |
The from..to//step syntax was introduced in Elixir v1.12.0 but hpax is compatible with Elixir versions going back to 1.7.0. So to fix the warning introduced in Elixir v1.17 we rewrite the guard without using a range at all.
|
@whatyouhide Updated. Should work on any version of Elixir now. |
|
Thanks @alco 💟 |
|
Can we have this pushed to a new version to silence the warning? :) |
|
Released v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the line emits a warning when compiled with Elixir 1.17