Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check argument types on HTTP1.request/5 #375

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Check argument types on HTTP1.request/5 #375

merged 1 commit into from
Aug 19, 2022

Conversation

britto
Copy link
Contributor

@britto britto commented Aug 17, 2022

The same way we do in HTTP2.request/5. Noticed it through dialyzer while passing a map of headers instead of a list.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4749efbeb0e1fbcda004b00dd31258ca9aeb4ec8-PR-375

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 84.987%
Files with Coverage Reduction New Missed Lines %
test/support/mint/http1/test_server.ex 1 84.62%
Totals Coverage Status
Change from base Build a947ca3e4c60d3bf0757ab457c465f949819ed71: -0.06%
Covered Lines: 1319
Relevant Lines: 1552
💛 - Coveralls

@britto britto marked this pull request as ready for review August 17, 2022 17:44
@whatyouhide whatyouhide merged commit 9e76b49 into elixir-mint:main Aug 19, 2022
@whatyouhide
Copy link
Contributor

Thanks @britto 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmj ericmj ericmj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@britto @coveralls @whatyouhide @ericmj