Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Elixir < 1.10 #388

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Drop support for Elixir < 1.10 #388

merged 3 commits into from
Feb 27, 2023

Conversation

whatyouhide
Copy link
Contributor

It's the oldest supported version by the Elixir team as of now.

@coveralls
Copy link

coveralls commented Feb 27, 2023

Pull Request Test Coverage Report for Build dadbe364be4f84aaf645df133462a1a77c2c59ee-PR-388

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 86.7%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/mint/core/transport/ssl.ex 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
lib/mint/core/transport/ssl.ex 2 82.17%
Totals Coverage Status
Change from base Build bb80a94afab40f8fd7cabdbb8d6a76f2580aa0f7: -0.08%
Covered Lines: 1219
Relevant Lines: 1406

💛 - Coveralls

@whatyouhide whatyouhide merged commit ca4e975 into main Feb 27, 2023
@whatyouhide whatyouhide deleted the al/elixir-1.10 branch February 27, 2023 15:01
@ericmj
Copy link
Member

ericmj commented Feb 27, 2023

We need 1.5 support for Hex but if it that becomes a problem for Mint then it may be best if Hex forks it from before this commit. Are there features from 1.5+ we want to use in Mint?

@whatyouhide
Copy link
Contributor Author

@ericmj oh, I completely missed that! There are a bunch, like is_struct/2 and stuff like that. I think we'll eventually have a hard time keeping support for as old as 1.5. I was thinking: should we keep the 1.4 release alive and have Hex use that instead? We can backport bug fixes if we deem necessary in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants