Add :inet4 transport option to disable IPv4 fallback #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3833933daaaf4939848a730e8860f4a8e5d6812c-PR-425Details
💛 - Coveralls |
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
wojtekmach
reviewed
Mar 15, 2024
| @@ -334,8 +335,11 @@ defmodule Mint.Core.Transport.SSL do | |||
| {:ok, sslsocket} -> | |||
| {:ok, sslsocket} | |||
|
|
|||
| _error -> | |||
| _error when inet4? -> | |||
There was a problem hiding this comment.
I believe stack mismatch shows up as :nxdomain so maybe there's no reason to try again on other error reasons? Or the idea is we get say :closed or :timeout and we might as well try on ipv4?
@dch you know more about this stuff, perhaps you have anything to add?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #395.