-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dialyxir and fix all warnings #27
Conversation
This helps to avoid matching on opaque structures, and removes the ambiguity that Dialyzer appeared to struggle with
7efdb97
to
6d394f3
Compare
Pull Request Test Coverage Report for Build 6d394f37eac7c2ce759e5f26480af700f023a93f-PR-27Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, this is looking good! 😀
I left some minor comments
Thank you! |
Thank you very much for Mint.WebSocket!
This PR adds :dialyxir to the project and runs it in CI.
When I added :dialyxir to this project, I saw there were warnings, so I fixed them in the best way(s) I knew how. I also cleaned some things up where I saw the opportunity to, such as in TestServer.