Efficiently read safetensors from disk #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josevalim sounds good! This makes a difference assuming that the binaries are garbage collected as we go. Do you know if the Erlang compiler would optimise it if we are not keeping a reference, or is it still going to be allocated globally? |
jonatanklosko
approved these changes
Sep 26, 2023
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
|
@jonatanklosko we don't know when the GC will run but this will at least allow the GC to run. We can also force it in the future by calling :erlang.garbage_collect for certain input sizes, but baby steps. :) |
|
💚 💙 💜 💛 ❤️ |
|
💯 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonatanklosko if you agree with the direction, it may be a good idea to use safetensor as the default way of loading models for Bumblebee. It puts lets pressure on memory.