Improve precompiled downloads #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes:
Adds integrity checking with checksums. When running
hex.publish, we now automatically generate achecksum.txtfile and include it in the hex package. Then, when we download the archive, we compare the checksum.We use
:httpcinstead of relying onwget/curlbeing installed. IIRC we did that initially to have an efficient stream download, instead of downloading the whole binary into memory, but the:httpcimplementation stream downloads also.We no longer query the GitHub API to list the release artifacts. Instead, we hard-code the list of precompiled targets in the module, so we know what's available upfront.
I removed
XLA_HTTP_HEADERSenv var. The original purpose was to allow GitHub auth token, to avoid GitHub API rate limiting on CI (Fail to download pre-build dll for Intel Mac #52 (comment)). With 3. this should be no longer necessary, since we don't query that API.Closes #92.