Update request body reading for cowboy 0.10.0 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this adds more clarity to the code.
| defcallback stream_req_body(payload, limit :: pos_integer) :: | ||
| {:ok, data :: binary, payload} | {:done, payload} | ||
| defcallback read_req_body(payload, options :: Keyword.t) :: | ||
| {:ok, data :: binary, payload} | {:more, payload} |
There was a problem hiding this comment.
Should this include {:error, term} as we expect that from the adapter in Conn.read_body?
|
There is a test failing: https://travis-ci.org/elixir-lang/plug/builds/27652502#L411 |
josevalim
pushed a commit
that referenced
this pull request
Jun 16, 2014
Update request body reading for cowboy 0.10.0
Gazler
pushed a commit
to Gazler/plug
that referenced
this pull request
Oct 18, 2018
…nction_calls Update request body reading for cowboy 0.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename collect_body to read_body and just delegate directly to the adapter.