Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI with current Elixir and Erlang/OTP versions #682

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

nathany-copia
Copy link
Contributor

@nathany-copia nathany-copia commented Jun 18, 2024

I am trying to maintain (in CI) the latest 2 major versions, so Elixir 15+ and OTP 25+; wait 2-3 months and it will be Elixir 16+ and OTP 26+

#623 (comment)

This approach runs fewer permutations, so we're not attempting an old version of Elixir on a new version of Erlang. We also can flag the latest version or release candidate as experimental, so that it doesn't block merging, but still reports the failures.

Comment on lines 102 to 85
elixir-version: '1.15'
otp-version: '25.3'
version-type: strict
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having an entirely separate job just to check code formatting may be overkill?

unless the idea is to continue-on-error for this particular check, but it's not running with a matrix right now anyway 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick one matrix (add some attribute to it) to do the formatting and lining and whatnot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I can give that a try. It's going to be a little tricky to know if I got that right on the first try though, given the "workflow awaiting approval" for testing CI.

1 workflow awaiting approval

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I ran mix format with a newer version of Elixir (as the old lint job was using 1.13)

@nathany-copia
Copy link
Contributor Author

@yordis @teamon What should be done about all the test failures, even on the "supported" Elixir 1.16 build?

> I am trying to maintain (in CI) the latest 2 major versions, so Elixir 15+ and OTP 25+; wait 2-3 months and it will be Elixir 16+ and OTP 26+

elixir-tesla#623 (comment)
@nathany-copia
Copy link
Contributor Author

@yordis @teamon Everything should be ready for a re-run in CI.

I've marked Elixir 1.16 as experimental until those test failures are fixed, which I think could be a separate pull request.

@nathany-copia
Copy link
Contributor Author

I think this should be good to merge now.

Then we can follow-up with a PR to get Elixir 1.16 passing and mark it as no longer "experimental" -- if that sounds okay to you?

@yordis
Copy link
Member

yordis commented Jun 19, 2024

Yeah, that works! Remember httparrot is the package that needs to be fixed or replace

@yordis yordis merged commit 3685f5f into elixir-tesla:master Jun 19, 2024
2 of 4 checks passed
@nathany-copia nathany-copia deleted the ci branch June 19, 2024 19:44
@nathany-copia
Copy link
Contributor Author

Yeah, that works! Remember httparrot is the package that needs to be fixed or replace

Opened #684 for that topic. Let's see if it can be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants