-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI with current Elixir and Erlang/OTP versions #682
Conversation
.github/workflows/test.yml
Outdated
elixir-version: '1.15' | ||
otp-version: '25.3' | ||
version-type: strict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having an entirely separate job just to check code formatting may be overkill?
unless the idea is to continue-on-error for this particular check, but it's not running with a matrix right now anyway 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pick one matrix (add some attribute to it) to do the formatting and lining and whatnot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I can give that a try. It's going to be a little tricky to know if I got that right on the first try though, given the "workflow awaiting approval" for testing CI.
1 workflow awaiting approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I ran mix format with a newer version of Elixir (as the old lint job was using 1.13)
> I am trying to maintain (in CI) the latest 2 major versions, so Elixir 15+ and OTP 25+; wait 2-3 months and it will be Elixir 16+ and OTP 26+ elixir-tesla#623 (comment)
I think this should be good to merge now. Then we can follow-up with a PR to get Elixir 1.16 passing and mark it as no longer "experimental" -- if that sounds okay to you? |
Yeah, that works! Remember |
Opened #684 for that topic. Let's see if it can be fixed. |
#623 (comment)
This approach runs fewer permutations, so we're not attempting an old version of Elixir on a new version of Erlang. We also can flag the latest version or release candidate as experimental, so that it doesn't block merging, but still reports the failures.