Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error message when formatting fails #463

Closed
teamon opened this issue May 10, 2024 · 0 comments · Fixed by #497 or #498
Closed

Missing error message when formatting fails #463

teamon opened this issue May 10, 2024 · 0 comments · Fixed by #497 or #498

Comments

@teamon
Copy link

teamon commented May 10, 2024

First of all - formatting works as expected.
What I did was I broke my local .formatter.exs by adding a non existing module to the list of plugins - this obviously causes formatting to stop working, and there is a message about it in logs but without the explanation why.

Broken .formatter.exs

[
  # ...
  plugins: [NOPE],
  # ...
]

Next LS logs inside Zed

[Next LS] Compiled !
[Next LS] Failed to format the file: file:///Users/teamon/code/headless/lib/headless.ex
[Next LS] Compiling 1 file (.ex)

When running with mix format there is an error message:

❯ mix format
Compiling 3 files (.ex)
** (Mix) Formatter plugin NOPE cannot be found

(What triggered my switch from Elixir LS to Next LS were the never ending issues with formatter loosing config and reformatting the whole file using lots of parenthesis. So far Next LS haven't failed me once there, amazing job!)

mhanberg added a commit that referenced this issue May 22, 2024
Shows error messages for well defined errors, but we don't receive
any signal that it failed for a plugin being missing, unfortunately.

Closes #463
mhanberg added a commit that referenced this issue May 22, 2024
Shows error messages for well defined errors, but we don't receive
any signal that it failed for a plugin being missing, unfortunately.

Closes #463
mhanberg added a commit that referenced this issue May 22, 2024
Shows error messages for well defined errors, but we don't receive
any signal that it failed for a plugin being missing, unfortunately.

Closes #463

refactor: bump styler and format

fix: handle change and save notifications before runtime is ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment