Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDPUtils.get_dtls_role/1. Handle multiple Group attributes. #82

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Mar 4, 2024

No description provided.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #82 (7d79110) into master (db45bcd) will increase coverage by 0.02%.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   88.96%   88.99%   +0.02%     
==========================================
  Files          31       31              
  Lines        1387     1390       +3     
==========================================
+ Hits         1234     1237       +3     
  Misses        153      153              
Files Coverage Δ
lib/ex_webrtc/sdp_utils.ex 90.40% <83.33%> (+0.23%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db45bcd...7d79110. Read the comment docs.

@mickel8 mickel8 changed the title Fix SDPUtils.get_dtls_role/1 Fix SDPUtils.get_dtls_role/1. Handle multiple Group attributes. Mar 5, 2024
@mickel8 mickel8 marked this pull request as ready for review March 5, 2024 21:06
@mickel8 mickel8 requested a review from LVala March 5, 2024 21:09
@mickel8 mickel8 merged commit 7a3412e into master Mar 6, 2024
4 checks passed
@mickel8 mickel8 deleted the get-dtls-role branch March 6, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants