Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #91

Merged
merged 16 commits into from
Mar 21, 2024
Merged

Improve CI #91

merged 16 commits into from
Mar 21, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Mar 21, 2024

This PR:

  • adds caching of deps, _build and dialyzer artifacts,
  • updates some of the actions versions (and thus removes warnings),
  • consolidates everything into a single GH Workflow job (both of previous jobs required compilation and now it's very fast anyways).

Thanks to this the CI should be much, much faster.

Based on https://fly.io/docs/elixir/advanced-guides/github-actions-elixir-ci-cd/ and https://www.alanvardy.com/post/caching-dialyzer with some tweaks here and there.

@LVala LVala requested a review from mickel8 March 21, 2024 12:29
@LVala LVala self-assigned this Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #91 (3afaf2c) into master (49dfba7) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   88.68%   88.74%   +0.05%     
==========================================
  Files          31       31              
  Lines        1503     1502       -1     
==========================================
  Hits         1333     1333              
+ Misses        170      169       -1     
Files Coverage Δ
lib/ex_webrtc/media/ivf/writer.ex 89.47% <100.00%> (+4.47%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49dfba7...3afaf2c. Read the comment docs.

@mickel8 mickel8 removed their request for review March 21, 2024 15:25
@LVala LVala requested a review from mickel8 March 21, 2024 18:12
@LVala LVala merged commit 07de1c1 into master Mar 21, 2024
3 checks passed
@LVala LVala deleted the improve-ci branch March 21, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants