Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faker.Food.PtBr #203

Merged
merged 10 commits into from
Aug 20, 2019
Merged

Faker.Food.PtBr #203

merged 10 commits into from
Aug 20, 2019

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Sep 29, 2018

I've added:

  • CHANGELOG.md
  • Add Faker.Food.PtBr
  • Fix Faker.StarWars doctests

@vbrazo vbrazo changed the title Add Faker.Food.PtBr locales Add Faker.Food.PtBr Sep 29, 2018
@igas
Copy link
Member

igas commented Oct 4, 2018

Hi @vbrazo,

It looks good to me, I'm planning to release bug fix release first and will merge it when we'll be doing next minor release.

@vbrazo
Copy link
Member Author

vbrazo commented Oct 4, 2018

@igas sounds good 🚀

@igas igas added this to the 0.12.0 milestone Oct 4, 2018
@vbrazo vbrazo changed the title Add Faker.Food.PtBr Faker.Food.PtBr Dec 31, 2018
@vbrazo vbrazo self-assigned this Feb 4, 2019
@vbrazo vbrazo modified the milestones: 0.12.0, 0.13.0 Feb 11, 2019
@anthonator
Copy link
Collaborator

Any reason this never got merged?

@anthonator anthonator merged commit f75935e into elixirs:master Aug 20, 2019
@vbrazo
Copy link
Member Author

vbrazo commented Aug 20, 2019

@anthonator no. We were actually just waiting for 0.13.0and it looks like we have a good amount of PRs to release a new version.

@vbrazo vbrazo deleted the locales/add-food-ptbr branch August 20, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants