-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Faker.Cannabis #269
Conversation
@igas just wanted to follow up on this PR. Have you had a chance to look at it & discuss with the other maintainers? The ruby faker project has a similar implementation for cannabis. https://github.com/stympy/faker/blob/master/lib/faker/default/cannabis.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently living in Vancouver/Canada and weed is legal here. Cannabis market is skyrocketing with some startups and cannabis is a commodity.
Even though this faker generator may not be heavily used, it'd be cool to have it. I'd probably include a namespace for it and add other faker "not too popular" generators in this namespace. Perhaps Faker.PopCulture.Cannabis
?
@vbrazo regarding the namespace comment: should other fakers like beer be under the |
I don't know if I agree with adding a |
I agree with @anthonator :) |
Just checking on this |
This PR includes modules for cannabis related data. Around the world, this is a rapidly growing industry and it would be good to have these modules included in faker.
I've added: