Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links to port 80 #22

Closed
jaimeiniesta opened this issue Apr 15, 2021 · 5 comments · Fixed by #25
Closed

Broken links to port 80 #22

jaimeiniesta opened this issue Apr 15, 2021 · 5 comments · Fixed by #25
Assignees
@jaimeiniesta @doomspork
Labels
bug Something isn't working elixir This work requires Elixir changes

Comments

@jaimeiniesta
Copy link
Contributor

I've run a Rocket Validator report on the beta site, and the crawler has found some broken links, on pages that use the 80 port:

https://rocketvalidator.com/s/5a71bc62-29c6-4e85-9ce5-2af0513f1976

Not sure yet if these are direct links or redirections, any idea?
@jaimeiniesta
Copy link
Contributor Author

Ah yes, definitely those links are on the front page:

Captura de pantalla 2021-04-15 a las 12 12 54

@jaimeiniesta jaimeiniesta mentioned this issue Apr 15, 2021
Merged
@doomspork doomspork added bug Something isn't working elixir This work requires Elixir changes labels Apr 15, 2021
doomspork pushed a commit that referenced this issue Apr 15, 2021
We only need to modify the path
bf4f54c 
Update the function to `_url` from `_link` to more accurately reflect
what it does. Only modify the request path, the entire url is not
necessary. Fixes #22.
@doomspork doomspork mentioned this issue Apr 15, 2021
Merged
doomspork pushed a commit that referenced this issue Apr 15, 2021
We only need to modify the path
a7134cd 
Update the function to `_url` from `_link` to more accurately reflect
what it does. Only modify the request path, the entire url is not
necessary. Fixes #22.
@jaimeiniesta
Copy link
Contributor Author

I still think this PR is needed, to fully configure the app to run in Heroku (if we're going to use Heroku, that's what I think was planned).

@doomspork
Copy link
Member

I'm good with merging if we can remove the SSL redirect until I can see about disable Cloudflare.

@doomspork
Copy link
Member

doomspork commented Apr 15, 2021 •
edited

This is currently deploying. We should be good to check if this fixed the issue in ~10 minutes.

If this does the trick we still need to get your fix RE: String.replace/3 into master whether that by via #25 or closing that in favor of a PR that only updates String.replace/3 to use global: false

doomspork pushed a commit that referenced this issue Apr 15, 2021
We only need to modify the path
8ec58ee 
Update the function to `_url` from `_link` to more accurately reflect
what it does. Only modify the request path, the entire url is not
necessary. Fixes #22.
@doomspork
Copy link
Member

Nice work @jaimeiniesta, this can be closed.

Closed via #23.

doomspork added a commit that referenced this issue Apr 16, 2021
@doomspork
We only need to modify the path (#25)
76390f5 
* We only need to modify the path

Update the function to `_url` from `_link` to more accurately reflect
what it does. Only modify the request path, the entire url is not
necessary. Fixes #22.

* Move setup to top level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaimeiniesta jaimeiniesta

@doomspork doomspork

Labels
bug Something isn't working elixir This work requires Elixir changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

We only need to modify the path elixirschool/school_house
2 participants
@jaimeiniesta @doomspork