-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configures production as explained in guides for Heroku #23
configures production as explained in guides for Heroku #23
Conversation
Howdy @jaimeiniesta! 🎉 I think we want some of this PR but not all of it. Some of the production configuration occurs at runtime in the I had to remove the I'll revisit the Cloudflare rules and see if that's the culprit. Until I can do that we'll need to drop that line. |
Sounds good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaimeiniesta with this suggested change I think we should be safe to merge. The domain needed to be updated and we can't use the force_ssl
option until I can clean up Cloudflare which appears to impact some other things so may take a little more effort.
LGTM |
I need to look into Heroku pipelines for testing out PRs. I'll try to carve out time this week or next to do that. |
Hi! Related to #22 I think I've found the cause, it looks like
config/prod.exs
needed some attention as per this guide.