Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: mock semver import #1006

Merged
merged 3 commits into from
Jan 12, 2023
Merged

perf: mock semver import #1006

merged 3 commits into from
Jan 12, 2023

Conversation

danielroe
Copy link
Member

this cuts 30kB of unused semver from the client-side bundle

@danielroe danielroe added the c: performance Related to performance label Jan 12, 2023
@danielroe danielroe self-assigned this Jan 12, 2023
@stackblitz
Copy link

stackblitz bot commented Jan 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 12, 2023 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit d11dfb5
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c01e0f966afb0009e8abdf

@netlify
Copy link

netlify bot commented Jan 12, 2023 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit d11dfb5
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c01e0f84c15f000970bf3c
😎 Deploy Preview https://deploy-preview-1006--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe marked this pull request as draft January 12, 2023 14:24
@sxzz
Copy link
Member

sxzz commented Jan 12, 2023

I'll refactor this part in masto.js

@danielroe danielroe marked this pull request as ready for review January 12, 2023 15:54
@danielroe Volta.net
Copy link
Member Author

What do you mean? I think we'll still need to mock semver to prevent it from being bundled.

@sxzz
Copy link
Member

sxzz commented Jan 12, 2023

Never mind. Let's get this merged first!

@danielroe danielroe merged commit 32aa47e into main Jan 12, 2023
@danielroe danielroe deleted the perf/remove-semver-2 branch January 12, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
c: performance Related to performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @sxzz