Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should hide tooltip when click outside #1123

Merged
merged 3 commits into from
Jan 15, 2023

Conversation

webfansplz
Copy link
Member

Closes #1062

@stackblitz
Copy link

stackblitz bot commented Jan 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 14, 2023

Deploy Preview for elk-docs ready!

Name Link
🔨 Latest commit 8af324d
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c459f9010f200008355119
😎 Deploy Preview https://deploy-preview-1123--elk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@edimitchel
Copy link
Collaborator

This should normally not be needed.
I think we need some @Akryum advice or confirmation it's a bug?

@Akryum
Copy link
Contributor

Akryum commented Jan 15, 2023

By default tooltips close on mouse out or blur, you shouldn't have to add this logic.
Also if you really need it, just put autoHide

@webfansplz
Copy link
Member Author

By default tooltips close on mouse out or blur, you shouldn't have to add this logic. Also if you really need it, just put autoHide

Thanks.

@webfansplz
Copy link
Member Author

This should normally not be needed. I think we need some @Akryum advice or confirmation it's a bug?

For #1062, it might make sense to add autoHide.

@netlify
Copy link

netlify bot commented Jan 15, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 5ee5594
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c3621a99cdd40008f57f9e
😎 Deploy Preview https://deploy-preview-1123--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

components/common/CommonTooltip.vue Outdated Show resolved Hide resolved
Co-authored-by: Michel EDIGHOFFER <edimitchel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolip not hide when click elsewhere.
5 participants