Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tiptap): add discord-style emoji suggestion support #1066

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

ahonn
Copy link
Contributor

@ahonn ahonn commented Jan 13, 2023

CleanShot 2023-01-14 at 11 15 23

CleanShot.2023-01-14.at.11.12.02.mp4

@stackblitz
Copy link

stackblitz bot commented Jan 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 774dccd
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c522297b1d840008945218

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 774dccd
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c52229490c200009a5b645
😎 Deploy Preview https://deploy-preview-1066--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sxzz sxzz changed the title feat: add discord-style emoji suggestion support feat(tiptap): add discord-style emoji suggestion support Jan 13, 2023
@sxzz
Copy link
Member

sxzz commented Jan 13, 2023

image

We suggest to provide a screenshot in PR.

@ahonn
Copy link
Contributor Author

ahonn commented Jan 14, 2023

image

We suggest to provide a screenshot in PR.

Done, and also added a video

@wakest
Copy link

wakest commented Jan 14, 2023

oh awesome! I was just about to make a issue about this! glad there is already a pr!

@danielroe
Copy link
Member

danielroe commented Jan 16, 2023

I'm currently getting double popups in Firefox on MacOS:

CleanShot 2023-01-16 at 01 05 35@2x

Edit: not reproducible now - maybe I had an outdated deployment?

I do notice the flickering when typing - is there a way we can make this smoother?

@ahonn
Copy link
Contributor Author

ahonn commented Jan 16, 2023

I do notice the flickering when typing

I don't quite understand what flickering when typing means here (suggestion width change?), can you elaborate?
And if we get double popups here, then mention/hashtag will have the same problem, and their implementations are basically the same.

@antfu
Copy link
Member

antfu commented Jan 16, 2023

@danielroe it should be fixed by #1123

@antfu antfu merged commit e847f8e into elk-zone:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants