feat: enhancements to profile account notifications #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
patak-dev
reviewed
Jan 14, 2023
|
Thanks @jeffsikes to work with others on this feature. We're going to be able to move a lot faster if we start to do cross-reviews like this. @rshigg could you add a review to this PR before we merge? |
rshigg
reviewed
Jan 15, 2023
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
4 tasks
patak-dev
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tooltip to the Account Header's new notify button. The tooltip text changes as the notify button is toggled from on to off.
Additionally, the icon has changed from a "jingle bell" to a "notification bell" icon which is consistent with the concept of "notifications" in Elk (the same type of icon is used for global notifications as well). This was a discussion that occurred on Jan 15th in the UI Discord channel.
Fixes #1124
Huge thanks to @rshigg for working on these changes with me, as we both worked on similar parts of the code in separate PRs! 🙌🏼
The videos below show all 4 states of the notification button:
Before
Screen.Recording.2023-01-14.at.10.36.58.PM.mov
After
Screen.Recording.2023-01-15.at.3.50.50.PM.mov
Tooltip Screenshots