-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): de-DE update locale #1188
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for elk-docs canceled.
|
/ping @Andre601 @T0TProduction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
I commented suggestions here and there
i did not comment on all "Sie" occurrences as we already agreed on discord that those should be updated 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@patak-dev Bit over-eager here with the merge as I hadn't time to give my review... |
@Andre601 please still do the review and create a new PR with your proposed changes. This PR was already quite big so it wasn't going to be easy to discuss everything anyways. |
Description
Update
de-DE
localesAdditional context
I updated these 143 missing locales completely automatically via VSCode i18n-ally
Lets review and check them 🙂
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).