Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): de-DE update locale #1188

Merged
merged 8 commits into from
Jan 15, 2023
Merged

feat(i18n): de-DE update locale #1188

merged 8 commits into from
Jan 15, 2023

Conversation

Shinigami92
Copy link
Member

Description

Update de-DE locales

Additional context

I updated these 143 missing locales completely automatically via VSCode i18n-ally
image

Lets review and check them 🙂


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Translations update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide related snapshots or videos.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Shinigami92 Shinigami92 added the c: i18n Enhance i18n label Jan 15, 2023
@Shinigami92 Shinigami92 self-assigned this Jan 15, 2023
@stackblitz
Copy link

stackblitz bot commented Jan 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 15, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit abdfae9
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c4554193f4e00009fd469a
😎 Deploy Preview https://deploy-preview-1188--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 15, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit abdfae9
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c455418112100009005e8b

locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
@Shinigami92
Copy link
Member Author

/ping @Andre601 @T0TProduction

locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
Copy link
Contributor

@maybeanerd maybeanerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
I commented suggestions here and there

i did not comment on all "Sie" occurrences as we already agreed on discord that those should be updated 😄

locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
locales/de-DE.json Outdated Show resolved Hide resolved
Copy link
Contributor

@maybeanerd maybeanerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@patak-dev patak-dev merged commit 656fd4b into main Jan 15, 2023
@patak-dev patak-dev deleted the i18n-de-DE-update branch January 15, 2023 19:38
@Andre601
Copy link
Contributor

@patak-dev Bit over-eager here with the merge as I hadn't time to give my review...

@patak-dev
Copy link
Member

@Andre601 please still do the review and create a new PR with your proposed changes. This PR was already quite big so it wasn't going to be easy to discuss everything anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n Enhance i18n
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants