Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pwa): add install PWA widget #1451

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

userquin
Copy link
Member

@userquin userquin commented Jan 25, 2023

This PR also changes dark icon color, too dark on update prompt.

install-light

install-dark

supersedes #1304

@stackblitz
Copy link

stackblitz bot commented Jan 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit abbff37
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63d13f07ea99ea0008ebe0df
😎 Deploy Preview https://deploy-preview-1451--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit abbff37
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63d13f07c31524000ae7e0f8

@userquin userquin mentioned this pull request Jan 25, 2023
9 tasks
@patak-dev patak-dev merged commit f96cdae into main Jan 25, 2023
@patak-dev patak-dev deleted the userquin/feat-pwa-install-widget branch January 25, 2023 15:26
@userquin userquin mentioned this pull request Jan 25, 2023
@ushuz
Copy link
Contributor

ushuz commented Jan 25, 2023

The install prompt won't go away if I don't install PWA

@userquin
Copy link
Member Author

@ushuz what browser?

@ushuz
Copy link
Contributor

ushuz commented Jan 25, 2023

@userquin MS Edge 108 on macOS

@userquin
Copy link
Member Author

@ushuz is there no another more complicated combination to test ;) (just joking)? PWA in macOS and iOS is a pain...

@msfjarvis
Copy link

@userquin I can also reproduce on Chrome 109.0.5414.119 on Linux. Here's what I did

  1. Load up https://main.elk.zone and observe the prompt on the bottom right
  2. Press dismiss button
  3. Click on the elk logo at top left to reload the page
  4. Observe the prompt re-appears

@userquin
Copy link
Member Author

userquin commented Jan 26, 2023

@ushuz @msfjarvis can you test it on main.elk.zone? Install widget will not appear again if cancelled from widget.

@ushuz
Copy link
Contributor

ushuz commented Jan 26, 2023

@userquin It's good for me now, looks like #1459 is related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants