Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GitHub card paths lookup #1563

Merged
merged 2 commits into from
Feb 1, 2023
Merged

fix: update GitHub card paths lookup #1563

merged 2 commits into from
Feb 1, 2023

Conversation

skryukov
Copy link
Contributor

@skryukov skryukov commented Feb 1, 2023

This PR fixes some problems with GitHub preview card:

  • it fixes a problem with parsing of repos with . in name
  • it also adds a fallback for (hopefully) all reserved paths from the github-reserved-names package. It also adds a whitelist for all supported reserved paths (only /sponsors/{username} at the moment)

Thread with some broken links:
https://elk.zone/universeodon.com/@elkdev/109790632883374579

@stackblitz
Copy link

stackblitz bot commented Feb 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit ca4fdc5
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63dab8b1e6ae1e0009ab9465

@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit ca4fdc5
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63dab8af9892180008d9560e
😎 Deploy Preview https://deploy-preview-1563--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I wonder if at some point we could avoid the new package by using some pattern in the description to know if it is a repository, issue, or PR. But given that we load this lazily, I think this is the safest way right now. Thanks for taking care of this 🙏🏼

@patak-dev patak-dev merged commit a025b3b into elk-zone:main Feb 1, 2023
@skryukov skryukov deleted the skryukov/fix-github-card-regexp-lookup branch February 2, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants