Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: french translations #1771

Merged
merged 2 commits into from
Feb 17, 2023
Merged

feat: french translations #1771

merged 2 commits into from
Feb 17, 2023

Conversation

edimitchel
Copy link
Collaborator

No description provided.

@edimitchel edimitchel requested a review from a team February 17, 2023 00:23
@stackblitz
Copy link

stackblitz bot commented Feb 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Feb 17, 2023 •
edited
Loading

✅ Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 88dd040
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63eecb9607b9220007f601e5

@netlify
Copy link

netlify bot commented Feb 17, 2023 •
edited
Loading

✅ Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 88dd040
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63eecb9632e9880008781e07
😎 Deploy Preview https://deploy-preview-1771--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

prazdevs
prazdevs approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@prazdevs prazdevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)
just wondering if we'd add a description for the "hide alt indicator" but it's not related to this PR only

@patak-dev patak-dev merged commit 4cc213c into main Feb 17, 2023
@patak-dev patak-dev deleted the feat/french-sync-translation branch February 17, 2023 10:41
emanuelpina pushed a commit to emanuelpina/elk that referenced this pull request Feb 18, 2023
@edimitchel @emanuelpina
feat: french translations (elk-zone#1771)
3a79782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@prazdevs prazdevs prazdevs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edimitchel @patak-dev @prazdevs