fix(default): update layout to use dynamic vh #1817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1279 which overflows the user avatar section and footer. The issue is documented here, where 100vh will take 100% of viewport height regardless of UI chrome. This is solved using the
dvh
unit which changes based on the UI.This issue only affects tablets at >1280px width (eg: 11/13in iPad Pro).
I'm not very knowledgable in unocss syntax, but copied the
scrollbar-hide
implementation since it applies a non-standard CSS rule-set. Reason being is if they are applied directly to tag (eg:<div h-screen h-100dvh>
, it can not apply correctly ifh-screen
is afterh-100dvh
in the stylesheet.The CSS rule I created merges the two to read like so:
Where it will apply 100dvh where it is supported, and 100vh elsewhere.