fix: wrap non-sensitive spoilers in spoiler status #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for elk-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #1633 that causes spoilers to be disabled if media is non-sensitive, when the expected behavior would be to: "enable spoilers as long as there's [spoiler text or sensitive media] or [if its filtered]".
I'm fairly sure that this should be as simple of a fix as that, but I think @ayoayco would be able to verify if anything else needs to be addressed.
(again, not evident in these screenshots but this post has
sensitive: false)Original instance (link):
Elk (canary link):
With this fix (preview link):
Fixes #1846.