Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pwa): add screenshots and orientation to webmanifest #2109

Merged
merged 17 commits into from
May 21, 2023

Conversation

userquin
Copy link
Member

@userquin userquin commented May 19, 2023

This PR includes:

  • update vite-plugin-pwa to 0.15.0 (ESM first)
  • add auth middleware in compose route
  • add PWA shourtcuts (96x96 and 192x192 icons): home, local, notifications, compose and settings (i18n)
  • add orientation, display and display_override and categories
  • remove shared_target type
  • fix compose widget error: https://discord.com/channels/1044887051155292200/1045783579520684062/1109169901442183238
  • fix sw.js and webmanifest, shiki and emojis files interception in the sw

@stackblitz
Copy link

stackblitz bot commented May 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented May 19, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 5d0bf1b
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/646a290d49134b0008ef8e81
😎 Deploy Preview https://deploy-preview-2109--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 19, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 5d0bf1b
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/646a290d12d8dd00088aa79c

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
vite-plugin-pwa@0.15.0 0.14.7...0.15.0 None +0/-0 userquin

modules/pwa/i18n.ts Outdated Show resolved Hide resolved
@userquin
Copy link
Member Author

we should change screenshots, we're using MS Store ones...

config/pwa.ts Outdated Show resolved Hide resolved
@userquin userquin marked this pull request as ready for review May 21, 2023 14:32
@danielroe danielroe changed the title feat(pwa): Add screenshots and orientation to webmanifest feat(pwa): add screenshots and orientation to webmanifest May 21, 2023
@danielroe danielroe merged commit dfb5a66 into main May 21, 2023
@danielroe danielroe deleted the userquin/feat-pwa-add-screenshots-and-orientation branch May 21, 2023 16:28
toufali pushed a commit to MozillaSocial/elk that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants