-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experimental features descriptions #2228
Merged
patak-dev
merged 5 commits into
elk-zone:main
from
iruldi:feat/add-experimental-features-description
Jul 14, 2023
Merged
feat: add experimental features descriptions #2228
patak-dev
merged 5 commits into
elk-zone:main
from
iruldi:feat/add-experimental-features-description
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
iruldi
changed the title
feat: add descriptions and en translations
feat: add experimental features descriptions
Jul 13, 2023
patak-dev
reviewed
Jul 13, 2023
patak-dev
reviewed
Jul 13, 2023
patak-dev
reviewed
Jul 13, 2023
Co-authored-by: patak <matias.capeletto@gmail.com>
Co-authored-by: patak <matias.capeletto@gmail.com>
Co-authored-by: patak <matias.capeletto@gmail.com>
@patak-dev Thanks for the review. It should be good now. |
patak-dev
approved these changes
Jul 14, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1142
Description
As suggested by issue #1142, just added descriptions to the current three experimental features available on preferences page.
I've seen that this PR #1239 didn't had any updates in months so I've decided to create a new one based on those translations.