Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide original post area in the edit widget #2283

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Jul 29, 2023

resolve #2276

You can also the alternative implementation (original flipping layout) for comparison: #2284

@stackblitz
Copy link

stackblitz bot commented Jul 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for elk-docs ready!

Name Link
🔨 Latest commit c637106
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/64c541d3c1451e0008ab2651
😎 Deploy Preview https://deploy-preview-2283--elk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit c637106
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/64c541d3ff3b4c0008a77cff
😎 Deploy Preview https://deploy-preview-2283--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the other PR for reference. I think both are good. Let's try hiding and we can change it if we receive further feedback.

@patak-dev patak-dev merged commit ee6ee30 into elk-zone:main Jul 29, 2023
13 checks passed
@shuuji3 shuuji3 deleted the feat/hide-original-post-in-edit-ui branch July 30, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider flipping the order of the Edit UI
2 participants