Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle follow request #2339

Merged
merged 8 commits into from
Oct 22, 2023
Merged

Conversation

Sma11X
Copy link
Contributor

@Sma11X Sma11X commented Aug 14, 2023

  • Allow locked users handle follow requests at notifications and use hover-card instead of the tips above the button
  • Add tips at the top of requested user card if user has requested a follow

Before

image

After

image

Tips

image

And I'm not sure if this is the appropriate style for the buttons, if has better ideas please let me know.

@stackblitz
Copy link

stackblitz bot commented Aug 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 6ce5d32
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6531081cc39c4500083ef12b

@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 6ce5d32
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6531081c0d8ef80008224f88
😎 Deploy Preview https://deploy-preview-2339--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sma11X Sma11X changed the title Feat/follow requests feat: handle follow request Aug 14, 2023
@patak-dev
Copy link
Member

Thanks! This is way better than before, we can merge it and keep improving later on. One thing that would be good is to have "Accept follow request" or similar in the notification. Maybe use a similar icon from the follow notification:
image

@Sma11X
Copy link
Contributor Author

Sma11X commented Oct 16, 2023

Thanks! This is way better than before, we can merge it and keep improving later on. One thing that would be good is to have "Accept follow request" or similar in the notification.

I used the same color as follow info and icon used before. And it changed as:
image

@Sma11X Sma11X requested a review from patak-dev October 16, 2023 10:01
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@patak-dev patak-dev added this pull request to the merge queue Oct 22, 2023
Merged via the queue into elk-zone:main with commit 5fceb70 Oct 22, 2023
12 checks passed
@Sma11X Sma11X deleted the feat/follow-requests branch October 23, 2023 01:09
@waldyrious
Copy link

Does this affect #709?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants