feat(i18n): Add Persian translation #2535

mehr32 · 2023-12-28T14:16:26Z

Hello, Farsi translation for elk with the help of friends:
@DrCode32
@sadraiiali

With the help : https://github.com/sadraiiali https://github.com/DrCode32/

stackblitz · 2023-12-28T14:16:28Z

Run & review this pull request in StackBlitz Codeflow.

netlify · 2023-12-28T14:16:31Z

✅ Deploy Preview for elk-docs canceled.

Name	Link
🔨 Latest commit	`926a59b`
🔍 Latest deploy log	https://app.netlify.com/sites/elk-docs/deploys/658db4ef8d692d0008e379c3

netlify · 2023-12-28T14:16:50Z

✅ Deploy Preview for elk-zone ready!

Name	Link
🔨 Latest commit	`926a59b`
🔍 Latest deploy log	https://app.netlify.com/sites/elk-zone/deploys/658db4efcface700079ddeed
😎 Deploy Preview	https://deploy-preview-2535--elk-zone.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

userquin · 2023-12-28T14:24:34Z

@mehr32 check https://github.com/elk-zone/elk/blob/main/CONTRIBUTING.md#adding-a-new-language

Check also https://github.com/elk-zone/elk/blob/main/CONTRIBUTING.md#named-interpolation if you need some custom plurals.

EDIT: check ar-EG here https://github.com/elk-zone/elk/blob/main/config/i18n.ts#L83-L92

locales/fa-IR.json

userquin · 2023-12-28T14:57:46Z

I'm fixing some entries in the json file, also adding the locale to be displayed in the settings, can you provide the persian locale in persian (fa-IR)?

userquin · 2023-12-28T15:03:22Z

فارسی

userquin · 2023-12-28T15:35:27Z

The docs not working and so we cannot check missing/outdated entries, here transaltion status from the json file (outdated entries should be removed and for missing, you should add them:

fa-IR translation status

"missing": [
      "compose.draft_title",
      "compose.drafts",
      "report.limiting",
      "report.mute_desc",
      "report.other",
      "report.other_desc",
      "report.reporting",
      "report.select_many",
      "report.select_one",
      "report.select_posts",
      "report.select_posts_other",
      "report.spam",
      "report.spam_desc",
      "report.submit",
      "report.unfollow_desc",
      "report.violation",
      "report.whats_wrong_account",
      "report.whats_wrong_post",
      "search.search_desc",
      "search.search_empty"
    ],
    "outdated": [
      "menu.open_in_original_site_2",
      "report.report.limiting",
      "report.report.mute_desc",
      "report.report.other",
      "report.report.other_desc",
      "report.report.reporting",
      "report.report.select_many",
      "report.report.select_one",
      "report.report.select_posts",
      "report.report.select_posts_other",
      "report.report.spam",
      "report.report.spam_desc",
      "report.report.submit",
      "report.report.unfollow_desc",
      "report.report.violation",
      "report.report.whats_wrong_account",
      "report.report.whats_wrong_post",
      "report.search.search_desc",
      "report.search.search_empty"
    ],

You also need to review lines 249 and 250, it seems you've duplicated entries with same translation: open_in_original_site and open_in_original_site2: keep only 1 using open_in_original_site key.

EDIT: review also the plurals entries, I just copy/paste it from ar-EG (a few lines above) in config/i18n.ts module.

Aslemammad · 2023-12-28T16:44:45Z

locales/fa-IR.json

+    "profile_description": "توضیحات بالای صفحه پروفایل {0}",
+    "profile_personal_note": "یادداشت شخصی",
+    "profile_unavailable": "پروفایل در دسترس نیست",
+    "reject": "رد درخواست دنبال‌ کردن",


isn't رد درخواست enough for this case?

Why, I'll fix it

it's just shorter and smoother.

Aslemammad · 2023-12-28T16:46:02Z

locales/fa-IR.json

+  },
+  "error": {
+    "account_not_found": "حساب {0} یافت نشد",
+    "explore_list_empty": "هیچ چیز داغی الآن وجود ندارد. بعداً بررسی کنید!",


instead of داغ can we have تازه ?

I don't think there is a problem. It looks smoother

Aslemammad · 2023-12-28T16:46:59Z

locales/fa-IR.json

+        "title": "ناوبری"
+      }
+    },
+    "sequence_then": "سپس"


why سپس ?

I think در ادامه دنباله is a better translation

Aslemammad · 2023-12-28T16:48:37Z

locales/fa-IR.json

+    "dialog_header": "میانبرهای صفحه‌کلید",
+    "groups": {
+      "actions": {
+        "boost": "بوست",


isn't بوست english?
any other alternative? but it's ok after all.

He is not, this is not correct in Farsi. A better translation is تقویت

Thank you so much, feel free to work on the issues, I just tried reviewing your amazing PR! Thank you.

I think تقویت means strengthening more! but let's go with it.

mehr32 · 2023-12-28T16:56:41Z

@userquin
You can easily tell me the problems that exist so that I can correct them. I didn't understand what you meant
And that
@Aslemammad
Will you correct these things that you said or should I correct them myself?

userquin · 2023-12-28T17:07:06Z

@mehr32 there is no problem, you should remove the outdated entries, not being used in Elk. You also need to include the missing entries

mehr32 · 2023-12-28T17:16:43Z

I reviewed the translation. Well, I don't know which ones are not used! I have considered the English Jason file as the base and translated it based on its values

One fact is that Elk does not have a good translation structure at all, you have to accept this! Why not use .po and .mo files? Why don't you make it simple to distinguish the translation file from changing the config file in a few lines of code?

mehr32 · 2023-12-28T17:21:03Z

I want to see why the app name is the same as "نام نرم‌افزار" in the preview? This is really bad, let me fix it

userquin · 2023-12-28T17:21:49Z

Why not use .po and .mo files?

do you have any ref/doc? we're using nuxt i18n module, I've no idea if supporting those formats.

userquin · 2023-12-28T17:25:25Z

Why don't you make it simple to distinguish the translation file from changing the config file in a few lines of code?

What do you mean?

mehr32 · 2023-12-28T17:28:12Z

In the corner of the screen, instead of Elk, the value of "نام نرم‌فزار" was displayed, which means the "name of the app"

mehr32 · 2023-12-28T17:32:45Z

i18n does not support .po or .mo directly, but it seems to be possible to implement it with gettext-parser in JavaScript and converting the file to an object. In general, I work with Python and do not know much

mehr32 · 2023-12-28T17:33:58Z

I think the correct translation has been used now. How can I have a preview?

userquin · 2023-12-28T17:35:41Z

How can I have a preview?

Go to home, and click on update button (when new version ready)

userquin · 2023-12-28T17:40:52Z

@mehr32 you should open PR preview in private browsing, this way when closing the window pwa resources will be automatically removed, between commits you can just close the private browsing window and reopen a new one, you'll get a fresh copy with a new fresh service worker (browser caches empty)

userquin · 2024-01-06T01:43:27Z

@mehr32 (not related directly with this PR) check LTR/RTL content support here #2545 and https://main.elk.zone (check #2541)

mehr32 added 2 commits December 28, 2023 12:12

Add Persian translation

0a7969e

With the help : https://github.com/sadraiiali https://github.com/DrCode32/

Update fa-IR.json

4e1f21c

userquin changed the title ~~Add Persian translation~~ feat(i18n): Add Persian translation Dec 28, 2023

userquin reviewed Dec 28, 2023

View reviewed changes

locales/fa-IR.json Outdated Show resolved Hide resolved

chore: include locale and fix translation file

8bbdeb0

Aslemammad reviewed Dec 28, 2023

View reviewed changes

Aslemammad approved these changes Dec 28, 2023

View reviewed changes

Update fa-IR.json

fc1dfd5

Update fa-IR.json

730e687

Update fa-IR.json

926a59b

patak-dev approved these changes Mar 4, 2024

View reviewed changes

patak-dev added this pull request to the merge queue Mar 4, 2024

Merged via the queue into elk-zone:main with commit c01a15c Mar 4, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(i18n): Add Persian translation #2535

feat(i18n): Add Persian translation #2535

mehr32 commented Dec 28, 2023

stackblitz bot commented Dec 28, 2023

netlify bot commented Dec 28, 2023 •

edited

Loading

netlify bot commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023

userquin commented Dec 28, 2023 •

edited

Loading

Aslemammad Dec 28, 2023

mehr32 Dec 28, 2023

Aslemammad Dec 28, 2023

Aslemammad Dec 28, 2023

mehr32 Dec 28, 2023

Aslemammad Dec 28, 2023

mehr32 Dec 28, 2023

Aslemammad Dec 28, 2023

Aslemammad Dec 28, 2023

mehr32 Dec 28, 2023

Aslemammad Dec 28, 2023

mehr32 commented Dec 28, 2023

userquin commented Dec 28, 2023

mehr32 commented Dec 28, 2023

mehr32 commented Dec 28, 2023

userquin commented Dec 28, 2023

userquin commented Dec 28, 2023

mehr32 commented Dec 28, 2023

mehr32 commented Dec 28, 2023

mehr32 commented Dec 28, 2023

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Jan 6, 2024 •

edited

Loading

feat(i18n): Add Persian translation #2535

feat(i18n): Add Persian translation #2535

Conversation

mehr32 commented Dec 28, 2023

stackblitz bot commented Dec 28, 2023

netlify bot commented Dec 28, 2023 • edited Loading

✅ Deploy Preview for elk-docs canceled.

netlify bot commented Dec 28, 2023 • edited Loading

✅ Deploy Preview for elk-zone ready!

userquin commented Dec 28, 2023 • edited Loading

userquin commented Dec 28, 2023 • edited Loading

userquin commented Dec 28, 2023

userquin commented Dec 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mehr32 commented Dec 28, 2023

userquin commented Dec 28, 2023

mehr32 commented Dec 28, 2023

mehr32 commented Dec 28, 2023

userquin commented Dec 28, 2023

userquin commented Dec 28, 2023

mehr32 commented Dec 28, 2023

mehr32 commented Dec 28, 2023

mehr32 commented Dec 28, 2023

userquin commented Dec 28, 2023 • edited Loading

userquin commented Dec 28, 2023 • edited Loading

userquin commented Jan 6, 2024 • edited Loading

netlify bot commented Dec 28, 2023 •

edited

Loading

netlify bot commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Dec 28, 2023 •

edited

Loading

userquin commented Jan 6, 2024 •

edited

Loading