Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search in command panel #576

Merged
merged 4 commits into from
Dec 28, 2022
Merged

feat: search in command panel #576

merged 4 commits into from
Dec 28, 2022

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented Dec 27, 2022

demo

image

@stackblitz
Copy link

stackblitz bot commented Dec 27, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Dec 27, 2022

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 25825e3
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63ac6100acc9820008268ed2
😎 Deploy Preview https://deploy-preview-576--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@LittleSound LittleSound marked this pull request as ready for review December 28, 2022 15:32
@patak-dev
Copy link
Member

This is amazing! Let's merge it ❤️

Two details I saw could be improved later:

  • When you scrolled down in a search, if you press Cmd+/ it should scroll back to the top. Right now you end up in the middle of the options
  • Unrelated to search, when you use the keyboard to navigate options in Cmd+/ the Activate badge on the right is a bit jumpy.

@patak-dev patak-dev merged commit a775203 into main Dec 28, 2022
@patak-dev patak-dev deleted the feat/search-in-command-panel branch December 28, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants