Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: push notification click #643

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Conversation

userquin
Copy link
Member

@userquin userquin commented Dec 29, 2022

Push notification click opens notifications/mention if notification type is mention, otherwise opens notifications page.

Push notification doesn't have the server and account, only the notification id (push) and the access token: push notification click will redirect to notifications or notifications/mention.

Check https://discord.com/channels/1044887051155292200/1045743591613534298/1058062934816858113 on discord for more info.

closes #636

@stackblitz
Copy link

stackblitz bot commented Dec 29, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Dec 29, 2022

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 4066030
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63adc53082291f000960c007
😎 Deploy Preview https://deploy-preview-643--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@TodePond
Copy link
Contributor

That's a big improvement even so 👍

@userquin userquin marked this pull request as ready for review December 29, 2022 16:52
@danielroe danielroe merged commit 9de4a14 into main Dec 29, 2022
@danielroe danielroe deleted the userquin/feat-push-notification-click branch December 29, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWA: Clicking on a notification doesn't lead to relevant place
3 participants