-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pwa): allow access elk users from service worker #662
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think we should still read from local storage and move the users to idb, then remove the key from LS. If not, everyone needs to re-login, no? |
Agreed - keeping it backwards-compatible would be nice 🙏 |
I need to review the redirection: check backward compatibility on users.ts, added users initialization function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge after other reviews, and test in main
for a couple of days. We should probably not do releases in the next two days.
@danielroe merging so we can test it. We can later check if we could reduce the duplication of types. |
This PR includes:
elk-users
storage toIDB-keyval
:useIDBKeyval
elk-users
and find the corresponding notification on backendnotification
ornotification/mention
ones (current behavior)This opens the doors to:
/cc @danielroe @TodePond