Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting default server via env #854

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jan 7, 2023

With this PR, it's possible to deploy Elk and set the default server by setting the NUXT_PUBLIC_DEFAULT_SERVER environment variable at runtime to the desired host name, e.g. universeodon.com.

cc: @supernovae

@patak-dev shall we also set default server to webtoo.ls in this PR?

related to #385

@danielroe danielroe self-assigned this Jan 7, 2023
@stackblitz
Copy link

stackblitz bot commented Jan 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 7, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 8d18c7e
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63b9a7cb63f0b30008e5cc25
😎 Deploy Preview https://deploy-preview-854--elk-zone.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev
Copy link
Member

@danielroe I think we should change it, but maybe better do it in a separate PR, just to leave this one clear for the future.

@patak-dev patak-dev merged commit 57fd9ae into main Jan 7, 2023
@patak-dev patak-dev deleted the feat/customise-default-server branch January 7, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants