Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alt button covers audio play button #911

Merged
merged 6 commits into from
Jan 9, 2023

Conversation

ayoayco
Copy link
Member

@ayoayco ayoayco commented Jan 9, 2023

fixes #809

A bit of a quick fix for now. This PR will put the ALT button to the side for audio attachments
Test audio post: https://deploy-preview-911--elk-zone.netlify.app/mstdn.social/@feditips/109644044918079289

Tested video, GIF, and images--they should stay the same (see screenshots at the bottom)

before after
Screenshot 2023-01-09 at 4 36 14 PM Screenshot 2023-01-09 at 4 34 09 PM
Screenshot 2023-01-09 at 4 35 23 PM Screenshot 2023-01-09 at 4 34 48 PM

Other media types should stay the same

Video: https://deploy-preview-911--elk-zone.netlify.app/mas.to/@ayodev/109660045793754684
Screenshot 2023-01-09 at 4 58 25 PM

GIF: https://deploy-preview-911--elk-zone.netlify.app/mas.to/@ayodev/109660075909387316
Screenshot 2023-01-09 at 4 59 56 PM

Image: https://deploy-preview-911--elk-zone.netlify.app/fosstodon.org/@viteconf/109659720641159906
Screenshot 2023-01-09 at 5 00 26 PM

@stackblitz
Copy link

stackblitz bot commented Jan 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit a21e6a8
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63bc624ae509a70008d4d1fb

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit a21e6a8
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63bc624ac45260000874bd63
😎 Deploy Preview https://deploy-preview-911--elk-zone.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ayoayco ayoayco changed the title fix: alt button covers media play action fix: alt button covers media play button Jan 9, 2023
@ayoayco ayoayco changed the title fix: alt button covers media play button fix: alt button covers audio play button Jan 9, 2023
@ayoayco ayoayco self-assigned this Jan 9, 2023
@ayoayco ayoayco marked this pull request as ready for review January 9, 2023 16:01
@ayoayco
Copy link
Member Author

ayoayco commented Jan 9, 2023

Still some issues on Safari! Seems the conditional for classes is ignored (?) -- I will fix that
Screenshot 2023-01-09 at 5 04 27 PM

This is fixed

@ayoayco ayoayco marked this pull request as draft January 9, 2023 16:54
@ayoayco ayoayco marked this pull request as ready for review January 9, 2023 18:55
@ayoayco ayoayco requested a review from patak-dev January 9, 2023 19:02
@patak-dev patak-dev merged commit d0675cb into main Jan 9, 2023
@patak-dev patak-dev deleted the fix/alt-text-covering-media-play-button branch January 9, 2023 19:33
@patak-dev
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alt badge overlays audio play button
2 participants