Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: even spacing of icons and text in navbar #995

Merged
merged 4 commits into from
Jan 16, 2023
Merged

fix: even spacing of icons and text in navbar #995

merged 4 commits into from
Jan 16, 2023

Conversation

so1ve
Copy link
Contributor

@so1ve so1ve commented Jan 12, 2023

No description provided.

@stackblitz
Copy link

stackblitz bot commented Jan 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 6fa0f5b
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/63c49d96a740bb0008fa3405

@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 6fa0f5b
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63c49d96d9ace100085bc4af
😎 Deploy Preview https://deploy-preview-995--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe
Copy link
Member

What was the problem?

@sxzz
Copy link
Member

sxzz commented Jan 12, 2023

Could you please provide a screenshot of before and after this PR?

@so1ve
Copy link
Contributor Author

so1ve commented Jan 13, 2023

Currently, these two texts are misaligned due to the different icon sizes - The size of notification icon is 20.25px x 20.25px, while others' is 22.5px x 22.5px.

@so1ve
Copy link
Contributor Author

so1ve commented Jan 13, 2023

Oh! Maybe we just need to remove an attribute.

@danielroe danielroe changed the title fix: make nav text display in the same column fix: even spacing of icons and text in navbar Jan 16, 2023
@danielroe danielroe merged commit 7c58d89 into elk-zone:main Jan 16, 2023
@so1ve so1ve deleted the fix/nav-text-column branch January 17, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants