Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl_light.css: ZOMFG and ROFL #1503

Closed
StealthWombat opened this issue Mar 25, 2014 · 3 comments
Closed

rtl_light.css: ZOMFG and ROFL #1503

StealthWombat opened this issue Mar 25, 2014 · 3 comments

Comments

@StealthWombat
Copy link
Contributor

.linkbutton:link, .linkbutton_right:link, .linkbutton_left:link,
.linkbutton:visited, .linkbutton_right:visited, .linkbutton_left:visited {
    border-left: 1px solid #afafaf;
    border-right: 1px solid #bfbfbf;
    box-shadow: -1px 1px 2px #e5e5e5;
}

/* Hover effects. */
.button_submit:hover, .right_submit:hover, .left_submit:hover,
.button_reset:hover,
.linkbutton:hover, .linkbutton_right:hover, .linkbutton_left:hover {
    border-left: 1px solid #ccc;
    border-right: 1px solid #afafaf;
    box-shadow: -2px 1px 1px rgba(0,0,0,0.07) inset;
}

Umm, what? Why is all this stuff in there? These are just button eye candy, As long as a button looks good, that's all that matters. There's absolutely no need to try and flip every damned style right to left just because the language changes. This applies to most elements.

This file should be almost empty. Rtl.css is just for positioning, and the vast majority of it should be done in the main rtl.css file.

@emanuele45
Copy link
Contributor

Better safe than sorry: I just took the normal css'es and flipped anything that looked asymmetric without even thinking what it was (my brain doesn't cope very well with CSS, so I had to switch it off 😛 ).

@StealthWombat
Copy link
Contributor Author

I'll see if I can devote some time to the CSS next month (April). I sspect there's still quite a bit to do on it before it's ready for RC, but I can't do much this month.

@emanuele45 emanuele45 modified the milestones: 1.0.1, 1.1 Beta Sep 8, 2014
@emanuele45 emanuele45 modified the milestones: 1.1 beta 2, 1.1 Beta 1 Oct 21, 2015
@emanuele45 emanuele45 modified the milestones: 1.1 beta 2, 1.1 beta 3 Jul 26, 2016
@emanuele45 emanuele45 modified the milestones: 2.0, 1.1 beta 3 Oct 1, 2016
@Spuds Spuds closed this as completed in 614354d Apr 29, 2024
Spuds added a commit that referenced this issue Apr 29, 2024
@Spuds
Copy link
Contributor

Spuds commented Apr 29, 2024

Its April ... 10 years later :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants