Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ Add Giphy Support #3763

Merged
merged 2 commits into from
Mar 4, 2024
Merged

+ Add Giphy Support #3763

merged 2 commits into from
Mar 4, 2024

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Mar 3, 2024

JS
CSS
Server Side Componetns

Add new option to include CSS with editor plugin

@Spuds Spuds added this to the 2.0 milestone Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 9.90991% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 32.99%. Comparing base (d68f678) to head (35ad943).
Report is 2 commits behind head on development.

Files Patch % Lines
sources/ElkArte/Controller/Giphy.php 0.00% 95 Missing ⚠️
sources/subs/Editor.subs.php 54.54% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3763      +/-   ##
=================================================
- Coverage          33.30%   32.99%   -0.32%     
- Complexity         16512    16529      +17     
=================================================
  Files                429      430       +1     
  Lines              83467    83574     +107     
=================================================
- Hits               27800    27573     -227     
- Misses             55667    56001     +334     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spuds Spuds merged commit f05bb79 into elkarte:development Mar 4, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant