fix: fix system tray not displaying anything #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
marking this as a draft until some testing has been done |
w-lfchen
commented
Aug 30, 2024
Comment on lines
-15
to
+19
| #[proxy(interface = "org.kde.StatusNotifierWatcher", assume_defaults = true)] | ||
| #[proxy( | ||
| default_service = "org.kde.StatusNotifierWatcher", | ||
| interface = "org.kde.StatusNotifierWatcher", | ||
| default_path = "/StatusNotifierWatcher" | ||
| )] |
There was a problem hiding this comment.
this change from the autogenerated file should probably be documented. i'm currently looking into 71ba502 again, maybe there's more
3 tasks
|
Merged, thanks a lot! No worries, mistakes happen, and I should have definitely been a bit more careful with my reviews ^^ |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes a regression introduced in 71ba502 by me not being careful enough when updating the auto-generated files.
i've reevaluated the commit and was unable to find further changes look like they are not just simple api changes.
closes #1170
#1180 might be related (sadly not, different issue)
Additional Notes
i want to note this down somewhere, waybar's files seem to originate from here, this might be a resource for future improvements/fixes
Checklist
cargo fmtto automatically format all code before committing