-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration format rework #221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0beadb1.
A pr of 116 commits... |
note: checks failing because of rust-lang/rust#88043 - nightly moment |
Awesome! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the massive PR you've all been waiting for!
We're replacing XML as the configuration language with a custom, s-expression based configuration syntax named
yuck
.yuck puts a lot of focus on providing clean, readable and useful error messages where possible, and aims to at some point allow for the implementation of advanced development-tooling such as a language server. To achieve that, eww is now split up into several crates:
dynval
value, which is a string-value that may be interpreted as a value of other types depending on where it is used. DynVal is thus the main primitive value type used for typejuggling, and replacesPrimVal
from the old eww codebase.Span
type used throughout the codebase.This PR is still work in progress for several reasons:
"
in shell-scripts - this shouldn't be hard, I just don't know what syntax to choose yetHowever - this is a cursive statement - but:
It should be usable. There might still be dealbreaking bugs, I haven't tested everything - if there are, please leave a comment here.
If you want to be the early adopter, feel free to give this a try! The syntax is (most likely, I'll not rule it out 100%, but it's very unlikely) not gonna go through any big changes - if any at all, those will be minor changes of keywords or some additions to syntax. So if your stuff that you do now works, it'll most likely continue working once this is fully finished!
Have fun!
PS: Note that this PR may get some force pushes still, as I do want to clean up the commit history - so maybe don't build big branches on top of this right now
Other changes
During work on this PR, some other changes have been made during refactorings.
--logs
flageww open
) don't find a daemonNotes / TODOs