Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elli_tcp: cast 'accepted' AFTER TLS handshake succeeded #85

Closed
wants to merge 1 commit into from

Conversation

sg2342
Copy link
Contributor

@sg2342 sg2342 commented May 18, 2020

fix #84

@coveralls
Copy link

coveralls commented May 18, 2020

Coverage Status

Coverage decreased (-0.03%) to 75.787% when pulling c919553 on sg2342:fix_tls_accept_logic into 968afee on elli-lib:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 75.787% when pulling 0698185 on sg2342:fix_tls_accept_logic into 21e2eeb on elli-lib:develop.

@paulo-ferraz-oliveira
Copy link
Contributor

@tsloughter: I could also benefit from this.

Any chance this gets merged into main instead?

[unless develop really does serve a different purpose - I use it in git-flow-oriented workflows, but in GitHub it seems to cause more pain than not]

@tsloughter
Copy link
Member

Oh, hm, yea, this is probably fine.

But pls reopen on main branch, we no longer are using develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed TLS handshakes spawn new acceptors
4 participants